-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standartize env variable in all documentation #545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
added
the
kind/documentation
Improvements or additions to documentation
label
Jan 7, 2025
furkatgofurov7
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are bunch of references from the docs which are impossible to check them all. Looks good, we can fix small issues if we missed anything iteratively in the future.
Danil-Grigorev
previously approved these changes
Jan 8, 2025
anmazzotti
previously approved these changes
Jan 8, 2025
alexander-demicev
force-pushed
the
fixenvvars
branch
from
January 8, 2025 10:16
de50291
to
a644356
Compare
salasberryfin
previously approved these changes
Jan 8, 2025
alexander-demicev
dismissed stale reviews from salasberryfin, furkatgofurov7, anmazzotti, and Danil-Grigorev
via
January 8, 2025 11:03
ec5438e
alexander-demicev
force-pushed
the
fixenvvars
branch
2 times, most recently
from
January 8, 2025 11:04
ec5438e
to
dd0a64b
Compare
Danil-Grigorev
approved these changes
Jan 8, 2025
alexander-demicev
force-pushed
the
fixenvvars
branch
from
January 8, 2025 12:36
dd0a64b
to
6385ead
Compare
furkatgofurov7
approved these changes
Jan 8, 2025
@alexander-demicev there is a commit signing problem, can you please fix it? |
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
fixenvvars
branch
from
January 8, 2025 15:11
6385ead
to
24c1f57
Compare
alexander-demicev
requested review from
salasberryfin,
anmazzotti,
Danil-Grigorev and
furkatgofurov7
January 8, 2025 15:11
anmazzotti
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #513
Special notes for your reviewer:
Checklist: