Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard nav for home page #12966

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 2, 2025

Summary

Fixes #12776

Occurred changes and/or fixed issues

  • Fix keyboard navigation on home page
  • checkbox is now visibly focusable
  • Banner component has correct roles, labels and is focusable
  • SortableTable component has been fixed for basic keyboard nav (sorting, checkboxes, links, open/close row action menu)

Technical notes summary

Areas or cases that should be tested

  • Go to the home page and browse the page with the tab key
  • use enter or space key to trigger UI elements on the page

Areas which could experience regressions

Screenshot/Video

Screen.Recording.2025-01-02.at.16.23.48.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think all the comments I left are fairly minor and have been addressed in other open accessibility PRs.

shell/components/BannerGraphic.vue Outdated Show resolved Hide resolved
shell/components/CommunityLinks.vue Outdated Show resolved Hide resolved
shell/components/SortableTable/THead.vue Outdated Show resolved Hide resolved
shell/pages/home.vue Outdated Show resolved Hide resolved
@aalves08 aalves08 requested a review from rak-phillip January 6, 2025 14:40
@aalves08 aalves08 force-pushed the 12776-fix-keyboard-nav-home-page branch from 7da65a7 to f7a177e Compare January 6, 2025 19:04
@aalves08 aalves08 force-pushed the 12776-fix-keyboard-nav-home-page branch from 072c566 to 4a2d31c Compare January 7, 2025 10:01
@aalves08 aalves08 requested a review from rak-phillip January 7, 2025 10:01
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 9553614 into rancher:master Jan 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation and focus display issues on the home screen
3 participants