Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Handling of Multiple Separators in Environment Variable Parsing #13071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skanakal
Copy link
Contributor

@skanakal skanakal commented Jan 12, 2025

Summary

Fixes #13070

Occurred changes and/or fixed issues

handle multiple separators (: and =) in a line by finding the index of the first occurrence of either separator using a regular expression. After identifying the separator, we use the substring method to separate the key and value.

Technical notes summary

Areas or cases that should be tested

As mentioned in the issue repro steps.

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox
Copy link
Member

This should be reviewed as part of the work for #12720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants