Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notificationBlockList to support new API warning messages format #13107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 14, 2025

Summary

Rancher head recently introduced API changes, previous version is v2.11-2053ce644a31cd8053d1f58e2487154b0b8513b6-head see #13111

  1. The format of warning messages in PUT response headers has changed:
    299 - unknown field "id" has become 299 - "unknown field "\id\""

  2. The PUT requests now send the warnings for fields we are sending in the PUT requests that are not expected.

  3. Some fields are missing from the response: id, links, type .

  4. Warnings are notified by growl dialogs. We should consider if this is the right approach or switch to console warnings

Occurred changes and/or fixed issues

Technical notes summary

Fixing point 1 in description.
We need to investigate whether the other points have an impact on the UI

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf changed the title Update notificationBlockList Update notificationBlockList Jan 14, 2025
@torchiaf torchiaf requested a review from richard-cox January 14, 2025 17:21
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

Just needs passing gates and description updated

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf added this to the v2.11.0 milestone Jan 15, 2025
@torchiaf torchiaf force-pushed the update-notificationBlockList branch from eeb3bc5 to 259974e Compare January 15, 2025 09:11
@torchiaf torchiaf marked this pull request as ready for review January 15, 2025 09:11
@torchiaf torchiaf requested a review from richard-cox January 15, 2025 09:16
@torchiaf torchiaf changed the title Update notificationBlockList Update notificationBlockList to support new API warning messages format Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants