Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKE1 agent config e2e tests #9247

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

mantis-toboggan-md
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md commented Jun 30, 2023

Summary

Fixes #8828

Requires Ember changes: rancher/ui#5046 merged

@mantis-toboggan-md
Copy link
Member Author

This is ready to review, though passing ci e2e will require rancher/ui#5046 to be merged

@gaktive gaktive requested a review from a user July 28, 2023 16:19
@mantis-toboggan-md
Copy link
Member Author

Updated to address review comments, fix rke2 pod affinity weighted term spec, and fix vscode typescript intellisense

@@ -0,0 +1,125 @@
import { LoginPagePo } from '@/cypress/e2e/po/pages/login-page.po';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's some merge issues with this file. it's showing up as new, but does exist in master at the moment https://github.com/rancher/dashboard/blob/master/cypress/support/commands/commands.ts

some commands have moved in to https://github.com/rancher/dashboard/blob/master/cypress/support/commands/rancher-api-commands.ts (like login), some have stayed byLabel, findId, getId, keyboardControls, interceptAllRequests and iFrame

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I derped. the new location is cypress/support/commands/commands.ts. If there are any changes in this PR to the file they need to be moved across

@richard-cox
Copy link
Member

richard-cox commented Aug 1, 2023

Sorry, one more issue. Looks like the admin tests all pass, however it takes 39 minutes to run the new rke1 agent config tests. This is a bit long for CI. We have an issue to start splitting this stuff out into buckets (ci, nightly, etc) but there could be something wrong with the test itself. Could you take a look, see where the logjams are (page reloads usually take a while, tests may be flaky requiring multiple attempts, etc)

@mantis-toboggan-md mantis-toboggan-md force-pushed the test-agent-config-rke1 branch 3 times, most recently from b223c3c to fdcad56 Compare August 2, 2023 21:47
@gaktive gaktive modified the milestones: v2.7.next3, v2.8.0 Aug 10, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Sep 28, 2023
@mantis-toboggan-md
Copy link
Member Author

Sorry, one more issue. Looks like the admin tests all pass, however it takes 39 minutes to run the new rke1 agent config tests. This is a bit long for CI.

It's definitely slower to load the ember iframed pages but that doesn't fully account for the run time. The only issue I was able to spot was super high memory use so I researched how I might ameliorate that. I was able to lower the test time to 11 minutes (admittedly still double the equivalent rke2 tests) by splitting each field of agent configs into their own describe block and setting NUM_TESTS_KEPT_IN_MEMORY to 0 ...I'm not confident I fully understand the implications of changing this setting, though.

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase (conflicts) would also be good to see how recent changes change anything.

In terms of CYPRESS_NUM_TESTS_KEPT_IN_MEMORY would be worth checking if the results are correctly uploaded to sorry cypress

@nwmac nwmac modified the milestones: v2.9.0, v2.10.0 Jul 2, 2024
@nwmac
Copy link
Member

nwmac commented Oct 25, 2024

@mantis-toboggan-md Should we bump this to 2.11?

@mantis-toboggan-md mantis-toboggan-md modified the milestones: v2.10.0, v2.11.0 Oct 25, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated tests for RKE1 agent configuration
4 participants