-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RKE1 agent config e2e tests #9247
base: master
Are you sure you want to change the base?
RKE1 agent config e2e tests #9247
Conversation
7451911
to
e648d50
Compare
This is ready to review, though passing ci e2e will require rancher/ui#5046 to be merged |
cypress/e2e/po/edit/provisioning.cattle.io.cluster/create/cluster-create-rke1-custom.po.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/po/edit/provisioning.cattle.io.cluster/create/cluster-create-rke1-custom.po.ts
Outdated
Show resolved
Hide resolved
560ef98
to
4d41e9d
Compare
5d57ab9
to
fda2d3d
Compare
fda2d3d
to
78cd56a
Compare
Updated to address review comments, fix rke2 pod affinity weighted term spec, and fix vscode typescript intellisense |
cypress/support/commands.ts
Outdated
@@ -0,0 +1,125 @@ | |||
import { LoginPagePo } from '@/cypress/e2e/po/pages/login-page.po'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's some merge issues with this file. it's showing up as new, but does exist in master
at the moment https://github.com/rancher/dashboard/blob/master/cypress/support/commands/commands.ts
some commands have moved in to https://github.com/rancher/dashboard/blob/master/cypress/support/commands/rancher-api-commands.ts (like login), some have stayed byLabel, findId, getId, keyboardControls, interceptAllRequests and iFrame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I derped. the new location is cypress/support/commands/commands.ts. If there are any changes in this PR to the file they need to be moved across
Sorry, one more issue. Looks like the admin tests all pass, however it takes 39 minutes to run the new rke1 agent config tests. This is a bit long for CI. We have an issue to start splitting this stuff out into buckets (ci, nightly, etc) but there could be something wrong with the test itself. Could you take a look, see where the logjams are (page reloads usually take a while, tests may be flaky requiring multiple attempts, etc) |
b223c3c
to
fdcad56
Compare
fdcad56
to
7a8eacb
Compare
It's definitely slower to load the ember iframed pages but that doesn't fully account for the run time. The only issue I was able to spot was super high memory use so I researched how I might ameliorate that. I was able to lower the test time to 11 minutes (admittedly still double the equivalent rke2 tests) by splitting each field of agent configs into their own describe block and setting NUM_TESTS_KEPT_IN_MEMORY to 0 ...I'm not confident I fully understand the implications of changing this setting, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase (conflicts) would also be good to see how recent changes change anything.
In terms of CYPRESS_NUM_TESTS_KEPT_IN_MEMORY would be worth checking if the results are correctly uploaded to sorry cypress
@mantis-toboggan-md Should we bump this to 2.11? |
Summary
Fixes #8828
Requires Ember changes: rancher/ui#5046merged