Propagate bundle and bundledeployment status updates to GitRepo #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
force-pushed
the
fix-gitrepo-status-updates
branch
2 times, most recently
from
9800688 to
c94d86e
Compare
A filter on status updates in the GitRepo reconciler prevents updates to statuses of bundles and bundle deployments from being reflected in their owning GitRepo's status. In turn, this leads to outdated and inconsistent GitRepo statuses. This commit remedies this, with a first attempt at covering GitRepo status updates in end-to-end tests.
Eliminating event filters would increase the number of reconcile loops, as each update to a `GitRepo`'s status would trigger a new loop. Instead, this commit restores event filters, widening the set of events allowed via predicates to bundle status updates.
This was already done for polling-based gitrepo testing, but missing for the webhook-based test case, which would lead to conflicts in some cases.
weyfonk
force-pushed
the
fix-gitrepo-status-updates
branch
from
e468c8d to
c4ad77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A filter on status updates in the GitRepo reconciler prevents updates to statuses of bundles and bundle deployments from being reflected in their owning GitRepo's status. In turn, this leads to outdated and inconsistent GitRepo statuses.
This updates those filters to ensure that bundle status updates are taken into account. End-to-end tests are updated as well to prevent future regressions.
Refers to #1972
Follow-up to #2018