[backport v2.9] [SURE-9137] Add template errors to bundle and gitrepo status #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3114) * Import v1alpha1 package as fleet * Show bundle errors in Bundle and GitRepo Refers to rancher#2943 * Add E2E tests Refers to rancher#2943 (cherry picked from commit 235e8ef) (cherry picked from commit 3417071)
p-se
changed the title
p-se
changed the title
weyfonk
reviewed
Jan 10, 2025
| @@ -215,6 +220,18 @@ func (r *BundleReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
|
|
|||
| matchedTargets, err := r.Builder.Targets(ctx, bundle, manifestID) | |||
There was a problem hiding this comment.
Do we want to take the opportunity to remove RetryOnConflict loops (around L150) for adding and removing finalizers here, as done for other release branches?
There was a problem hiding this comment.
Is that like a one liner? Otherwise it sounds to me like a different issue/PR.
manno
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import v1alpha1 package as fleet
Show bundle errors in Bundle and GitRepo
Refers to #2943
Refers to #2943
(cherry picked from commit 235e8ef) (cherry picked from commit 3417071)
Refers to #3191