Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.7] Add ACI-CNI 6.1.1.2 variables #3765

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jeffinkottaram
Copy link
Contributor

@jeffinkottaram jeffinkottaram commented Dec 31, 2024

@jeffinkottaram jeffinkottaram requested a review from a team as a code owner December 31, 2024 11:15
@jeffinkottaram jeffinkottaram changed the title Add ACI-CNI 6.1.1.2 variables [release/v1.7] Add ACI-CNI 6.1.1.2 variables Dec 31, 2024
Copy link
Member

@kinarashah kinarashah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffinkottaram Could you run go generate and commit modified data files

@mitulshah-suse
Copy link
Contributor

@jeffinkottaram KDM changes are merged.. can u update the data files again?

@vardhaman22
Copy link
Contributor

need to rerun go generate and add these files as well

 types/kdm/zz_generated_deepcopy.go
 types/zz_generated_deepcopy.go

there is a change in copyright comment in these files after doing go generate

@jeffinkottaram
Copy link
Contributor Author

Added the requested files. PTAL, @mitulshah-suse, @vardhaman22

Copy link
Contributor

@mitulshah-suse mitulshah-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitulshah-suse mitulshah-suse merged commit bf9d23a into rancher:release/v1.7 Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants