Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storageclass.yaml): Add option for 'reclaimPolicy' #70

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Mart-Kuc
Copy link

@Mart-Kuc Mart-Kuc commented Apr 9, 2024

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • Chart version has been incremented (if necessary)
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Feature: Add option for reclaimPolicy in storageclass.yaml.
This feature allow change default value for reclaimPolicy from Delete to Retain.

Linked Issues

None

Additional Notes

  • Default value in values.yaml is set to Delete, so no breaking changes and fully compatibility.
  • Tested on vSphere Client v. 8.0.2, K8S v1.27.12, provider RKE2.
  • Tested with default reclaim policy (Delete) and with Retain policy.
  • Helm lint

Lint

After the PR is merged

Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.

Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
Could you rebase the PR and address my comment?

charts/rancher-vsphere-csi/Chart.yaml Outdated Show resolved Hide resolved
@Mart-Kuc Mart-Kuc force-pushed the feat/storageclass-policy branch from da83300 to 401c550 Compare September 5, 2024 08:38
@Mart-Kuc Mart-Kuc requested review from a team as code owners September 5, 2024 08:38
charts/rancher-vsphere-csi/Chart.yaml Outdated Show resolved Hide resolved
@Mart-Kuc Mart-Kuc force-pushed the feat/storageclass-policy branch from 401c550 to 41a7c6b Compare September 5, 2024 08:56
@brandond brandond requested a review from jiaqiluo September 5, 2024 08:57
charts/rancher-vsphere-csi/Chart.yaml Outdated Show resolved Hide resolved
@jiaqiluo jiaqiluo merged commit e33d9a5 into rancher:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants