Update CSI images for K8s 1.29 and CPI images for K8s 1.29/1.30 support #81
Conversation
There was a problem hiding this comment.
One comment to address.
Also CI is failing - looks like one of the tests needs to be updated (or maybe it's catching actual issue? 🤷 )
https://github.com/rancher/vsphere-charts/actions/runs/9444377823/job/26054730155#step:5:1200
krunalhinguu
force-pushed
the
1.29-support
branch
from
273a6aa to
0feefeb
Compare
There was a problem hiding this comment.
@krunalhinguu , LGTM now - thank you for updating the versions range and fixing YAML formatting to get CI to pass (tests are actually helpful!).
|
Can we add CPI 1.30 support here as well? It has been available for ~3 weeks now. |
@brandond , this is planned to be done as part of rancher/rancher#45746 but I wouldn't mind if it's rolled into this PR. @krunalhinguu , up to you if you want to tack it onto this PR or open a separate one. |
|
sure @snasovich . Adding 1.30 support for CPI as part of this PR as it wont make much difference raising in separate PR |
krunalhinguu
force-pushed
the
1.29-support
branch
from
0feefeb to
adbc31d
Compare
snasovich
changed the title
Pull Request Checklist
Types of Change
Linked Issues
After the PR is merged
Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.