Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old k8s version support < 1.27 #84

Merged

Conversation

thatmidwesterncoder
Copy link
Contributor

@thatmidwesterncoder thatmidwesterncoder commented Jul 25, 2024

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • Chart version has been incremented (if necessary)
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Removing old version support. Basically involved removing versionOverride entries + tests for those old versions.

Linked Issues

rancher/rancher#46146

Additional Notes

After the PR is merged

Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.

@thatmidwesterncoder thatmidwesterncoder marked this pull request as ready for review July 29, 2024 17:26
@thatmidwesterncoder thatmidwesterncoder requested review from a team as code owners July 29, 2024 17:26
@thatmidwesterncoder thatmidwesterncoder merged commit 321c5cd into rancher:main Jul 29, 2024
1 check passed
@thatmidwesterncoder thatmidwesterncoder deleted the remove_old_versions branch July 29, 2024 19:37
thatmidwesterncoder added a commit to thatmidwesterncoder/vsphere-charts that referenced this pull request Jul 30, 2024
thatmidwesterncoder added a commit that referenced this pull request Jul 30, 2024
…tation

fix kube-version annotation to reflect #84 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants