Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNR] Add multi-source reading to JSON reader benchmarks #17688

Draft
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Jan 7, 2025

Description

Depends on #17708
Enables benchmarking of multi-source multi-batch JSON reader by adding another axis for number of input sources in the benchmark.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Jan 7, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 7, 2025
@shrshi shrshi changed the title Add multi-source reading to JSON reader benchmarks [DNR] Add multi-source reading to JSON reader benchmarks Jan 7, 2025
@shrshi
Copy link
Contributor Author

shrshi commented Jan 7, 2025

Null probability has been set to zero in the random table generator so that the JSON reader benchmark does not fail for multi-source multi-batch reading. Once issue #17689 is resolved, the change to the table generator will be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant