Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf._lib.scalar in favor of pylibcudf #17701

Open
wants to merge 17 commits into
base: branch-25.02
Choose a base branch
from
Open

Remove cudf._lib.scalar in favor of pylibcudf #17701

wants to merge 17 commits into from

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jan 9, 2025 •
edited
Loading

Description

This PR changes cudf.Scalar.device_scalar to be a pylibcudf.Scalar object instead of a cudf._lib.scalar.DeviceScalar.

Most of the conversion logic previously in cudf._lib.scalar.DeviceScalar now lives in python/cudf/cudf/core/scalar.py

Some tests that exercised behaviors of cudf.Scalar.device_scalar when it was a cudf._lib.scalar.DeviceScalar were modified/removed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 9, 2025
@mroeschke mroeschke self-assigned this Jan 9, 2025
@mroeschke mroeschke requested review from a team as code owners January 9, 2025 02:14
@github-actions github-actions bot added the CMake CMake build issue label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroeschke