-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuML dask fixes to unblock CI #6170
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
For the two dask related problems, do we have an upstream issue (in dask land) to track this? Even if they say "this is a feature, not a bug". I was mostly thinking that we are modifying the cuml tests here to make them pass, but presumably the tests got put here because someone thought users should be able to do this. So if we can do something simple to point users to an issue that explains why something that used to work suddenly has stopped working that would be great. Otherwise this looks uncontroversial?! |
@betatim I agree we need to open them, haven't opened them yet because I don't have a repro without dask yet, but we should open them once we have some |
This is the error from the "build in devcontainer" CI run. Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks good and CI should pass.
/merge |
Thanks team! We got CI passing again! 🥳 |
PR includes commits from #6166 to run CI while that one is merged.
Dask nightlies break a few things in cuML, mainly the following two issues: #6168, #6169
Closes #6166.