Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuML dask fixes to unblock CI #6170

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Dec 9, 2024

PR includes commits from #6166 to run CI while that one is merged.

Dask nightlies break a few things in cuML, mainly the following two issues: #6168, #6169

Closes #6166.

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Dec 9, 2024
Copy link

copy-pr-bot bot commented Dec 9, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Dec 9, 2024
@dantegd
Copy link
Member Author

dantegd commented Dec 9, 2024

/ok to test

@betatim
Copy link
Member

betatim commented Dec 9, 2024

For the two dask related problems, do we have an upstream issue (in dask land) to track this? Even if they say "this is a feature, not a bug". I was mostly thinking that we are modifying the cuml tests here to make them pass, but presumably the tests got put here because someone thought users should be able to do this. So if we can do something simple to point users to an issue that explains why something that used to work suddenly has stopped working that would be great.

Otherwise this looks uncontroversial?!

@dantegd
Copy link
Member Author

dantegd commented Dec 9, 2024

@betatim I agree we need to open them, haven't opened them yet because I don't have a repro without dask yet, but we should open them once we have some

@dantegd dantegd marked this pull request as ready for review December 9, 2024 18:35
@dantegd dantegd requested review from a team as code owners December 9, 2024 18:35
@dantegd dantegd requested review from bdice and betatim December 9, 2024 18:35
@betatim
Copy link
Member

betatim commented Dec 10, 2024

                     from /home/coder/cuml/cpp/build/pip/cuda-12.5/release/_deps/rmm-src/include/rmm/mr/device/pool_memory_resource.hpp:34,
  
                     from /home/coder/cuml/cpp/build/pip/cuda-12.5/release/_deps/raft-src/cpp/include/raft/core/resource/device_memory_resource.hpp:26,
  
                     from /home/coder/cuml/cpp/build/pip/cuda-12.5/release/_deps/raft-src/cpp/include/raft/core/device_resources.hpp:32,
  
                     from /home/coder/cuml/cpp/build/pip/cuda-12.5/release/_deps/raft-src/cpp/include/raft/core/handle.hpp:19,
  
                     from /home/coder/cuml/python/cuml/build/pip/cuda-12.5/release/cuml/cluster/kmeans.cxx:1072:
    /home/coder/cuml/cpp/build/pip/cuda-12.5/release/_deps/cccl-src/thrust/thrust/cmake/../../thrust/system/cuda/config.h:122:2: error: #error The version of CUB in your include path is not compatible with this release of Thrust. CUB is now included in the CUDA Toolkit, so you no longer need to use your own checkout of CUB. Define THRUST_IGNORE_CUB_VERSION_CHECK to ignore this.
      122 | #error The version of CUB in your include path is not compatible with this release of Thrust. CUB is now included in the CUDA Toolkit, so you no longer need to use your own checkout of CUB. Define THRUST_IGNORE_CUB_VERSION_CHECK to ignore this.
          |  ^~~~~
    ninja: build stopped: subcommand failed.

This is the error from the "build in devcontainer" CI run. Any ideas?

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good and CI should pass.

@bdice
Copy link
Contributor

bdice commented Dec 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 858bd9f into rapidsai:branch-25.02 Dec 11, 2024
64 of 65 checks passed
@bdice
Copy link
Contributor

bdice commented Dec 11, 2024

Thanks team! We got CI passing again! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants