Further fixes for Scipy 1.15 update for PR and nightly CI #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
dantegd
added
bug
|
/ok to test |
|
/ok to test |
viclafargue
approved these changes
Jan 13, 2025
betatim
reviewed
Jan 13, 2025
| @@ -629,7 +629,7 @@ def test_logistic_regression_model_default(dtype): | |||
|
|
|||
|
|
|||
| @given( | |||
| dtype=floating_dtypes(sizes=(32, 64)), | |||
| dtype=st.sampled_from((np.float32, np.float64)), | |||
There was a problem hiding this comment.
For my education: can you explain a bit why this is needed? A quick look at floating_dtypes makes me think it also uses sampled_from on the inside. But maybe returns strings instead of dtype objects?
There was a problem hiding this comment.
The floating_dtypes will generate all possible dtypes for the given sizes, including those with different endianness:
>>> from hypothesis.extra.numpy import floating_dtypes
>>> f = floating_dtypes(sizes=(16,32))
>>> f.example()
dtype('float16')
>>> f.example()
dtype('>f2')
>>> f.example()
dtype('float32')
>>> f.example()
dtype('>f4')
>>> f.example()
dtype('float16')The change here represents an stronger assumption on the expected types.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly CI revealed a bug between hypothesis
floating_dtypes(sizes=(32, 64)and building sparse matrices, this PR usesst.sampled_from((np.float32, np.float64)to solve the issue.Additionally, cudf.pandas active made one dataset in ARIMA pytests fail, so disabling that one while we look further into it.