Use GCC 13 in CUDA 12 conda builds. #6221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
KyleFromNVIDIA
approved these changes
Jan 13, 2025
|
Seeing the following error on CI: 2025-01-13T19:13:00.8954431Z inlined from 'static cudaError_t cub::CUB_200700_700_750_800_860_900_NS::DeviceReduce::TransformReduce(void*, size_t&, InputIteratorT, OutputIteratorT, NumItemsT, ReductionOpT, TransformOpT, T, cudaStream_t) [with InputIteratorT = int*; OutputIteratorT = int*; ReductionOpT = thrust::plus<int>; TransformOpT = cuda::__4::__detail::__return_type_wrapper<bool, __nv_dl_wrapper_t<__nv_dl_trailing_return_tag<void (ML::HDBSCAN::Common::CondensedHierarchy<int, float>::*)(int*, int*, float*, int*, int), &ML::HDBSCAN::Common::CondensedHierarchy<int, float>::condense, bool, 1> > >; T = int; NumItemsT = int]' at $SRC_DIR/cpp/build/_deps/cccl-src/cub/cub/cmake/../../cub/device/device_reduce.cuh:1000:143:
2025-01-13T19:13:00.8957470Z $SRC_DIR/cpp/build/_deps/cccl-src/thrust/thrust/cmake/../../thrust/system/cuda/detail/core/triple_chevron_launch.h:143:19: error: 'dispatch' may be used uninitialized [-Werror=maybe-uninitialized]
2025-01-13T19:13:00.8958686Z 143 | NV_IF_TARGET(NV_IS_HOST, (return doit_host(k, args...);), (return doit_device(k, args...);));
2025-01-13T19:13:00.8959168Z | ~~~~~~~~~^~~~~~~~~~~~ |
bdice
commented
Jan 14, 2025
| @@ -420,6 +420,25 @@ if(BUILD_CUML_CPP_LIBRARY) | |||
| src/hdbscan/hdbscan.cu | |||
| src/hdbscan/condensed_hierarchy.cu | |||
| src/hdbscan/prediction_data.cu) | |||
|
|
|||
| set_property( | |||
There was a problem hiding this comment.
@divyegala We need a comment about why these are here. Can you add a link to an issue everywhere that this workaround was used?
Suggested change
| set_property( | |
| # When using GCC 13, some maybe-uninitialized warnings appear from CCCL and are treated as errors. | |
| # See this CCCL issue: <INSERT LINK HERE> | |
| set_property( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.
These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.