-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple from shared-workflows #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf6932d.
raydouglass
reviewed
May 1, 2024
ajschmidt8
reviewed
May 1, 2024
This reverts commit 66ca84c.
vyasr
added a commit
that referenced
this pull request
May 1, 2024
This PR updates the build job that occurs on pushes to main to also use the reusable workflow from #2. It also adds logic to check if a push to main has modified the VERSION file. If so, the new package is published if tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the GHA workflows here independent of those in rapidsai/shared-workflows. It extracts the necessary logic into self-contained workflows so that we are not tied to the RAPIDS branching/versioning strategy. In addition, it splits the core logic into a shared workflow that can be used for both building and publishing, which will enable downstream work to actually start publishing packages.