Enable subproject filters for projects with subprojects #11674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least shows the UI element if it makes sense to show. Currently there's no way without knowing the query syntax to get subprojects, which has caused confusion for a few of our users and broke existing behavior. Refs #11638
stsewd
approved these changes
Oct 14, 2024
stsewd
reviewed
Oct 14, 2024
humitos
approved these changes
Oct 15, 2024
readthedocs/proxito/views/hosting.py
Outdated
| superproject = project.superprojects.first().parent | ||
| data["addons"]["search"]["filters"].append( | ||
| [ | ||
| "Include subprojects", |
There was a problem hiding this comment.
If you are reading a subproject, you want to get results from sibling projects -- since subprojects don't have other subprojects, but sibling ones.
Suggested change
| "Include subprojects", | |
| "Include sibling projects", |
There was a problem hiding this comment.
I think subprojects is fine for the text here to not confuse users. If I go from a parent project to a subproject, it will be weird to have the text copy change in that case -- they are still "subprojects" in a certain sense, and I think keeping the UX the same makes it clearer.
Co-authored-by: Manuel Kaufmann <[email protected]>
stsewd
reviewed
Oct 15, 2024
| f"subprojects:{project.slug}/{version.slug}", | ||
| ] | ||
| ) | ||
| if project.superprojects.exists(): |
There was a problem hiding this comment.
This can save one query, since a project can't be both, a superproject and subproject.
Suggested change
| if project.superprojects.exists(): | |
| elif project.superprojects.exists(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least shows the UI element if it makes sense to show.
Currently there's no way without knowing the query syntax to get subprojects,
which has caused confusion for a few of our users and broke existing behavior.
Refs #11638