Don't log if indentation isn't set in config

Fixes #1998

CHANGELOG.md

@@ -10,7 +10,9 @@
 
 #### Bug Fixes
 
-* None.
+* No longer log if the `indentation` key isn't set in the configuration file.  
+  [JP Simard](https://github.com/jpsim)
+  [#1998](https://github.com/realm/SwiftLint/issues/1998)
 
 ## 0.24.1: Dented Tumbler
 

Source/SwiftLintFramework/Extensions/Configuration+Parsing.swift

@@ -41,6 +41,19 @@ extension Configuration {
         ].map({ $0.rawValue }) + ruleList.allValidIdentifiers()
     }
 
+    private static func getIndentationLogIfInvalid(from dict: [String: Any]) -> IndentationStyle {
+        if let rawIndentation = dict[Key.indentation.rawValue] {
+            if let indentationStyle = Configuration.IndentationStyle(rawIndentation) {
+                return indentationStyle
+            }
+
+            queuedPrintError("Invalid configuration for '\(Key.indentation)'. Falling back to default.")
+            return .default
+        }
+
+        return .default
+    }
+
     public init?(dict: [String: Any], ruleList: RuleList = masterRuleList, enableAllRules: Bool = false,
                  cachePath: String? = nil) {
         func defaultStringArray(_ object: Any?) -> [String] {
@@ -62,10 +75,7 @@ extension Configuration {
         let whitelistRules = defaultStringArray(dict[Key.whitelistRules.rawValue])
         let included = defaultStringArray(dict[Key.included.rawValue])
         let excluded = defaultStringArray(dict[Key.excluded.rawValue])
-        let indentation = Configuration.IndentationStyle(dict[Key.indentation.rawValue]) ?? {
-            queuedPrintError("Invalid configuration for '\(Key.indentation)'. Falling back to default.")
-            return .default
-        }()
+        let indentation = Configuration.getIndentationLogIfInvalid(from: dict)
 
         Configuration.warnAboutDeprecations(configurationDictionary: dict, disabledRules: disabledRules,
                                             optInRules: optInRules, whitelistRules: whitelistRules, ruleList: ruleList)