RCPP-8 Prepare vcpkg for submission #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leemaguire
commented
May 29, 2024
•
leemaguire
commented
- This PR moves the default scheduler logic into the SDK layer to allow better flexibility.
- The CMakeLists have also been updated to not point to the realm-core submodule if the vcpkg toolchain is detected.
- The GHA vcpkg workflow now checks out the latest vcpkg, as the built in one points to some older version.
- The Qt scheduler has been removed as it was never actually used by any platform, users should provide their own scheduler if needs be.
fealebenpae
reviewed
Jun 6, 2024
leemaguire
force-pushed
the
lm/vcpkg
branch
2 times, most recently
from
ef06e64 to
9602d2b
Compare
kneth
approved these changes
Jun 18, 2024
| @@ -49,6 +54,13 @@ add_compile_definitions(REALM_ENABLE_ENCRYPTION) | |||
| add_compile_definitions(REALM_INSTALL_LIBEXECDIR) | |||
| add_compile_definitions(REALM_BUILD_LIB_ONLY) | |||
|
|
|||
| # on Apple platforms we use the built-in CFRunLoop | |||
| # everywhere else it's libuv, except UWP where it doesn't build | |||
There was a problem hiding this comment.
And I assume that UWP is checked by WINDOWS_STORE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.