Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky waitForInitialData_resilientInCaseOfRetriesAsync #5441

Closed
wants to merge 1 commit into from
Closed

Fix flaky waitForInitialData_resilientInCaseOfRetriesAsync #5441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion realm/realm-library/src/syncIntegrationTest/java/io/realm/SyncedRealmTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ public void run() {
// needed to correctly test all error paths.
@Test
@RunTestInLooperThread
@Ignore("See https://github.com/realm/realm-java/issues/5373")
public void waitForInitialData_resilientInCaseOfRetriesAsync() {
SyncCredentials credentials = SyncCredentials.usernamePassword(UUID.randomUUID().toString(), "password", true);
SyncUser user = SyncUser.login(credentials, Constants.AUTH_URL);
Expand All @@ -179,6 +178,7 @@ public void onError(Throwable exception) {
SystemClock.sleep(randomizer.nextInt(5));
task.cancel();
}
TestHelper.waitRealmThreadExecutorFinish();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RunTestInLooperThread does this automatically: https://github.com/realm/realm-java/blob/master/realm/realm-library/src/androidTest/java/io/realm/rule/RunInLooperThread.java#L287 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, right. i missed that. then it probably has the same issue with https://github.com/realm/realm-sync/issues/1770

looperThread.testComplete();
}

Expand Down