Migrate and reenable sync realm integration test #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
reviewed
Aug 27, 2020
realm/realm-library/src/androidTestObjectServer/kotlin/io/realm/AppConfigurationTests.kt
Outdated
Show resolved
Hide resolved
cmelchior
reviewed
Aug 27, 2020
| try { | ||
| assertTrue(Realm.deleteRealm(config)) | ||
| } catch (e: IllegalStateException) { | ||
| // FIXME: We don't have a way to ensure that the Realm instance on client thread has been |
There was a problem hiding this comment.
Hmm, I think I saw something about this being fixed. Try talking to @RedBeard0531
There was a problem hiding this comment.
The old issue #5416 is still open. I have tried incorporating the shutdown_and_wait from realm/realm-object-store#1055 but had various issue around it. In some of the other tests referring to #5416 I was not able to get hold of the session and other places like here it did not work out. Reapplied a workaround from another test by retried to close if it fails.
There was a problem hiding this comment.
Maybe related to some internal notification triggering to early due to realm/realm-object-store#1054
cmelchior
reviewed
Aug 27, 2020
realm/realm-library/src/syncIntegrationTest/kotlin/io/realm/SyncedRealmIntegrationTests.kt
Outdated
Show resolved
Hide resolved
cmelchior
reviewed
Aug 27, 2020
realm/realm-library/src/syncIntegrationTest/kotlin/io/realm/SyncedRealmIntegrationTests.kt
Outdated
Show resolved
Hide resolved
cmelchior
reviewed
Aug 27, 2020
realm/realm-library/src/syncIntegrationTest/kotlin/io/realm/SyncedRealmIntegrationTests.kt
Outdated
Show resolved
Hide resolved
edualonso
approved these changes
Sep 3, 2020
clementetb
requested changes
Sep 3, 2020
realm/realm-library/src/androidTestObjectServer/kotlin/io/realm/ProgressListenerTests.kt
Show resolved
Hide resolved
realm/realm-library/src/syncIntegrationTest/kotlin/io/realm/SyncedRealmIntegrationTests.kt
Show resolved
Hide resolved
clementetb
approved these changes
Sep 14, 2020
cmelchior
approved these changes
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues:
A number of tests requires sessions to be closed, but we loose grip of them as tests intentionally triggers exceptions on
getInstance. Already tracked in #5416. Tried incorporatingshutdown_and_waitfrom realm/realm-object-store#1055 but did not solve the issue. Maybe dependant on realm/realm-object-store#1054 too.