Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMB][Automation]CLI Command #4383

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

MohitBis
Copy link
Contributor

Automated SMB CLI command verification
Scenarios:
Verify that the smb cli cluster listing command correctly lists all SMB clusters.
Verify that the smb cli share listing command correctly lists all SMB shares.
Verify that the smb cli show command correctly show SMB resource.
Verify that the smb cli dump cluster-config command correctly give cluster-config.
Verify that the smb cli dump service-spec command correctly give service-spec details.

@MohitBis
Copy link
Contributor Author

@MohitBis MohitBis added smb samba DMFG Deployment and management changes labels Jan 16, 2025
Signed-off-by: Mohit Bisht <[email protected]>
Copy link
Contributor

@adityaramteke adityaramteke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 20, 2025
Copy link
Contributor

@pranavprakash20 pranavprakash20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adityaramteke, MohitBis, pranavprakash20

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 48ebf07 into red-hat-storage:main Jan 20, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DMFG Deployment and management changes lgtm Add this label when the PR is good to be merged smb samba
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants