Removing the sync folder option using rsync #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Gilmore <[email protected]>
As it is not applicable on Virtualbox running on Windows Fixes issue redhat-imaging#366 Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
issue-366-remove-sync-windows
branch
from
ef0822b to
6443c02
Compare
|
So what is the status here really? |
| @@ -1247,7 +1247,7 @@ def sync(self): | |||
|
|
|||
| vagrantfile = '''Vagrant.configure("2") do |config| | |||
| config.vm.base_mac = "%s" | |||
| config.vm.synced_folder ".", "%s", type: "rsync" | |||
| config.vm.synced_folder ".", "/vagrant", disabled: true | |||
There was a problem hiding this comment.
@imcleod I should have removed the line config.vm.synced_folder ".", "%s", type: "rsync" instead of disabling it.
|
@ausil I saw your commit with my commit in this PR. Not sure is this intentional or some git magic. I am planning to close this PR and open a new one. Do you have other suggestion for me? |
|
I have no idea how that happened. looks like you pulled in a commit I did |
What's the issue for that and when is this going to happen? TBH, I doubt the use of rsync as enforced default strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is not applicable on Virtualbox running on Windows
Fixes issue #366
Signed-off-by: Lalatendu Mohanty [email protected]