-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4531 set data type examples #3076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @andy-stark-redis
apologies for this but it seems @uglide already implemented the StringExample.java
as part of #3051
Perhaps we should leave only the SetExample.java
in this PR?
This reverts commit 60768b8.
…ettuce into DOC-4531-set-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I only have one comment, that we may decide not to address. Thanks for your work on this!
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.DOC-4531
Examples for this page.
Note that the Strings example file is just a copy of the one that was already in the doctests branch. It has already been reviewed.