Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4531 set data type examples #3076

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Dec 13, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

DOC-4531

Examples for this page.

Note that the Strings example file is just a copy of the one that was already in the doctests branch. It has already been reviewed.

@andy-stark-redis andy-stark-redis marked this pull request as ready for review December 13, 2024 16:12
@tishun tishun added the type: documentation A documentation update label Jan 16, 2025
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @andy-stark-redis

apologies for this but it seems @uglide already implemented the StringExample.java as part of #3051
Perhaps we should leave only the SetExample.java in this PR?

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I only have one comment, that we may decide not to address. Thanks for your work on this!

@tishun tishun merged commit 5911303 into redis:main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants