Add duration and duration_ms for logfmt format #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something that is being considered? It would be really helpful to have the duration_ms in the logfmt format. Or is this something that should be solved in a different manner? |
|
Looks good, can you try merging master again? Github won't let me fix the conflict myself. |
Log processors sometimes parse duration_human as string (because of the added 'ms') which is not always useful.
woutersmeenk
force-pushed
the
logfmt-duration
branch
from
b5fbe89 to
56e391e
Compare
|
@reidmorrison Rebased the branch. |
|
@reidmorrison Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Pull requests will not be accepted without a description of this change under the
[unreleased]sectionin the file
CHANGELOG.Description of changes
Add :duration_ms to Logfmt formatter
Log processors sometimes parse duration_human as string (because of the added 'ms') which is not always useful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.