-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-84613 Playwright tags are parsed to the RP's attributes and attached to the tests #133
Merged
AmsterGet
merged 21 commits into
reportportal:feature/EPMRPP-84613-playwright-tags-to-rp-attributes
from
abdelrhman-arnos:EPMRPP-84613
Mar 8, 2024
Merged
EPMRPP-84613 Playwright tags are parsed to the RP's attributes and attached to the tests #133
AmsterGet
merged 21 commits into
reportportal:feature/EPMRPP-84613-playwright-tags-to-rp-attributes
from
abdelrhman-arnos:EPMRPP-84613
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes and attached to the tests
AmsterGet
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also don't forget to cover your changes with tests and update readme file with new section Attributes
under Reporting
chapter with the guide how to use the feature.
AmsterGet
requested changes
Feb 6, 2024
AmsterGet
requested changes
Feb 8, 2024
AmsterGet
reviewed
Mar 5, 2024
Co-authored-by: Ilya <[email protected]>
Co-authored-by: Ilya <[email protected]>
AmsterGet
reviewed
Mar 6, 2024
Co-authored-by: Ilya <[email protected]>
Co-authored-by: Ilya <[email protected]>
Co-authored-by: Ilya <[email protected]>
AmsterGet
requested changes
Mar 7, 2024
AmsterGet
approved these changes
Mar 8, 2024
AmsterGet
changed the base branch from
develop
to
feature/EPMRPP-84613-playwright-tags-to-rp-attributes
March 8, 2024 14:14
AmsterGet
merged commit Mar 8, 2024
e970e5c
into
reportportal:feature/EPMRPP-84613-playwright-tags-to-rp-attributes
2 checks passed
@abdelrhman-arnos thanks for the feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags from Playwright should be converted into ReportPortal attributes and associated with the respective tests. If the test name carries tags as per the Playwright annotation conventions, these tags need to be included as test attributes in ReportPortal. Conversely, the test name itself should appear in ReportPortal without these tags.
For example, a test titled
Test login page @tag
should appear in ReportPortal as 'Test login page' with an attribute that reads{ value: 'tag' }
. Any tests that do not carry tags should be reported in their original format.Additionally, if the configuration passed to the agent accommodates the
grep
orgrep-invert
options, corresponding attributes should be appended to the entire launch entity in ReportPortal.