Skip to content

Commit

Permalink
changing params behavior to be required as Resend docs (#79)
Browse files Browse the repository at this point in the history
  • Loading branch information
pedroimpulcetto authored Apr 22, 2024
1 parent 0b072b4 commit c460760
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion resend/api_keys/_api_keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def list(cls) -> List[ApiKey]:
return [ApiKey.new_from_request(val) for val in resp["data"]]

@classmethod
def remove(cls, api_key_id: str = "") -> None:
def remove(cls, api_key_id: str) -> None:
"""
Remove an existing API key.
see more: https://resend.com/docs/api-reference/api-keys/delete-api-key
Expand Down
8 changes: 4 additions & 4 deletions resend/domains/_domains.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def update(cls, params: UpdateParams) -> Domain:
)

@classmethod
def get(cls, domain_id: str = "") -> Domain:
def get(cls, domain_id: str) -> Domain:
"""
Retrieve a single domain for the authenticated user.
see more: https://resend.com/docs/api-reference/domains/get-domain
Expand Down Expand Up @@ -101,10 +101,10 @@ def list(cls) -> List[Domain]:
return [Domain.new_from_request(val) for val in resp["data"]]

@classmethod
def remove(cls, domain_id: str = "") -> Domain:
def remove(cls, domain_id: str) -> Domain:
"""
Remove an existing domain.
see more: https://resend.com/docs/api-reference/domains/remove-domain
see more: https://resend.com/docs/api-reference/domains/delete-domain
Args:
domain_id (str): The domain ID
Expand All @@ -118,7 +118,7 @@ def remove(cls, domain_id: str = "") -> Domain:
)

@classmethod
def verify(cls, domain_id: str = "") -> Domain:
def verify(cls, domain_id: str) -> Domain:
"""
Verify an existing domain.
see more: https://resend.com/docs/api-reference/domains/verify-domain
Expand Down
2 changes: 1 addition & 1 deletion resend/emails/_emails.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def send(cls, params: SendParams) -> Email:
)

@classmethod
def get(cls, email_id: str = "") -> Email:
def get(cls, email_id: str) -> Email:
"""
Retrieve a single email.
see more: https://resend.com/docs/api-reference/emails/retrieve-email
Expand Down

0 comments on commit c460760

Please sign in to comment.