Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gstr-1): handle gov api error when downloading and make it optional for unfiled returns (backport #2897) #2934

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 8, 2025

…al for unfiled returns (#2897)

Co-authored-by: Sanket322 <shahsanket322003.com>
Co-authored-by: Smit Vora <[email protected]>
(cherry picked from commit 49a431e)
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 59.79%. Comparing base (bba95e4) to head (744fedc).
Report is 31 commits behind head on version-15-hotfix.

Files with missing lines Patch % Lines
...st_india/doctype/gst_return_log/generate_gstr_1.py 0.00% 9 Missing ⚠️
...gst_india/doctype/gst_return_log/gst_return_log.py 12.50% 7 Missing ⚠️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-15-hotfix    #2934      +/-   ##
=====================================================
- Coverage              59.86%   59.79%   -0.07%     
=====================================================
  Files                    122      122              
  Lines                  12131    12145      +14     
=====================================================
  Hits                    7262     7262              
- Misses                  4869     4883      +14     
Files with missing lines Coverage Δ
india_compliance/gst_india/setup/__init__.py 34.16% <ø> (ø)
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <0.00%> (ø)
...gst_india/doctype/gst_return_log/gst_return_log.py 25.15% <12.50%> (-0.32%) ⬇️
...st_india/doctype/gst_return_log/generate_gstr_1.py 14.64% <0.00%> (-0.23%) ⬇️

Impacted file tree graph

@mergify mergify bot merged commit 8aac3bb into version-15-hotfix Jan 8, 2025
12 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-2897 branch January 8, 2025 07:14
@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 15.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants