Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique name for events and doctype parameter alone is redundant (backport #2903) #2939

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 8, 2025

Huly®: IC-3030


This is an automatic backport of pull request #2903 done by Mergify.

@mergify mergify bot added the conflicts label Jan 8, 2025
Copy link
Contributor Author

mergify bot commented Jan 8, 2025

Cherry-pick of dc0be5d has failed:

On branch mergify/bp/version-14-hotfix/pr-2903
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit dc0be5df.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   india_compliance/gst_india/doctype/gstr_1_beta/gstr_1_beta.js
	modified:   india_compliance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py
	modified:   india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.py
	modified:   india_compliance/gst_india/utils/gstr_1/gstr_1_download.py
	modified:   india_compliance/gst_india/utils/gstr_2/__init__.py
	modified:   india_compliance/gst_india/utils/gstr_2/gstr.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   india_compliance/gst_india/doctype/gst_return_log/gst_return_log.py
	both modified:   india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@vorasmit vorasmit removed the conflicts label Jan 8, 2025
@mergify mergify bot merged commit dfa4ba7 into version-14-hotfix Jan 8, 2025
12 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-2903 branch January 8, 2025 09:38
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (8455e7d) to head (2b4122c).
Report is 23 commits behind head on version-14-hotfix.

Files with missing lines Patch % Lines
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           version-14-hotfix    #2939   +/-   ##
==================================================
  Coverage              61.02%   61.02%           
==================================================
  Files                    115      115           
  Lines                  11173    11174    +1     
==================================================
+ Hits                    6818     6819    +1     
  Misses                  4355     4355           
Files with missing lines Coverage Δ
...gst_india/doctype/gst_return_log/gst_return_log.py 18.51% <ø> (ø)
...nce/gst_india/doctype/gst_settings/gst_settings.py 76.56% <ø> (ø)
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <ø> (ø)
...econciliation_tool/purchase_reconciliation_tool.py 24.00% <100.00%> (+0.17%) ⬆️
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 22.22% <ø> (ø)
india_compliance/gst_india/utils/gstr_2/gstr.py 93.75% <ø> (ø)
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 61.48% <25.00%> (ø)

Impacted file tree graph

@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 14.30.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants