Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectively download sections in GSTR-1 based on summary information (backport #2938) #2954

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

Reduces Number of API calls.

  • Handle Nil Return
  • Handle Sections with zero values

Huly®: IC-3065


This is an automatic backport of pull request #2938 done by Mergify.

@mergify mergify bot merged commit da11f4b into version-14-hotfix Jan 10, 2025
12 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-2938 branch January 10, 2025 13:09
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (7ddbd00) to head (6249f05).
Report is 17 commits behind head on version-14-hotfix.

Files with missing lines Patch % Lines
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 17.64% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-14-hotfix    #2954      +/-   ##
=====================================================
- Coverage              61.02%   60.96%   -0.07%     
=====================================================
  Files                    115      115              
  Lines                  11174    11187      +13     
=====================================================
+ Hits                    6819     6820       +1     
- Misses                  4355     4367      +12     
Files with missing lines Coverage Δ
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 19.40% <17.64%> (-2.82%) ⬇️

Impacted file tree graph

@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 14.30.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants