Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes Related to IMS #2998

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix: Fixes Related to IMS #2998

wants to merge 3 commits into from

Conversation

Ninad1306
Copy link
Contributor

No description provided.

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: IC-3126

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (465eced) to head (4eb8ca3).

Files with missing lines Patch % Lines
...management_system/gst_invoice_management_system.py 0.00% 3 Missing ⚠️
..._compliance/gst_india/api_classes/taxpayer_base.py 0.00% 2 Missing ⚠️
india_compliance/gst_india/utils/api.py 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2998   +/-   ##
========================================
  Coverage    57.39%   57.39%           
========================================
  Files          126      126           
  Lines        12678    12678           
========================================
+ Hits          7276     7277    +1     
+ Misses        5402     5401    -1
Files with missing lines Coverage Δ
...iance/gst_india/doctype/gstr_action/gstr_action.py 41.66% <ø> (+4.82%) ⬆️
..._compliance/gst_india/api_classes/taxpayer_base.py 24.36% <0.00%> (-0.21%) ⬇️
india_compliance/gst_india/utils/api.py 87.50% <66.66%> (-12.50%) ⬇️
...management_system/gst_invoice_management_system.py 0.00% <0.00%> (ø)

Impacted file tree graph

@Ninad1306 Ninad1306 marked this pull request as draft January 22, 2025 12:27
vorasmit
vorasmit reviewed Jan 22, 2025
View reviewed changes
..._compliance/gst_india/doctype/gst_invoice_management_system/gst_invoice_management_system.js
@@ -347,6 +347,11 @@ class IMS extends reconciliation.reconciliation_tabs {
align: "center",
width: 120,
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

along with bill number

vorasmit
vorasmit reviewed Jan 22, 2025
View reviewed changes
..._compliance/gst_india/doctype/gst_invoice_management_system/gst_invoice_management_system.py
frappe.db.get_value(
"Integration Request", {"name": integration_request}, "data"
)
frappe.db.get_value("Integration Request", {"request_id": request_id}, "data")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets throw so that we know if this fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorasmit vorasmit vorasmit left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ninad1306 @vorasmit