Skip to content

Commit

Permalink
feat: add svelte 5
Browse files Browse the repository at this point in the history
  • Loading branch information
Ni55aN committed Dec 28, 2024
1 parent 88a7cd7 commit 7d67690
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
fail-fast: false
max-parallel: 1
matrix:
version: [4,3]
version: [5,4,3]
uses: ./.github/workflows/regression.yml
with:
name: svelte
Expand Down
4 changes: 2 additions & 2 deletions src/commands/init/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const targets: { stack: App.AppStack, versions: number[] }[] = [
{ stack: 'react-vite', versions: [16, 17, 18] },
{ stack: 'vue', versions: [2, 3] },
{ stack: 'angular', versions: [12, 13, 14, 15, 16, 17, 18] },
{ stack: 'svelte', versions: [3, 4] },
{ stack: 'svelte', versions: [3, 4, 5] },
{ stack: 'lit-vite', versions: [3] }
]
export const stackNames = targets.map(t => t.stack)
Expand All @@ -24,7 +24,7 @@ export function getFeatures({ stack, version }: Pick<(typeof fixtures)[0], 'stac
stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15 | 16 | 17 | 18, next),
['react', 'react-vite'].includes(stack) && new App.Features.React(version, stack, next),
stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),
stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),
stack === 'svelte' && new App.Features.Svelte(version as 3 | 4 | 5, next),

Check failure on line 27 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / Prepare tools / Rete QA / retejs/rete-qa#svelte-5

Argument of type '3 | 4 | 5' is not assignable to parameter of type '3 | 4'.
stack === 'lit-vite' && new App.Features.Lit(version as 3, next),
new App.Features.ZoomAt(),
new App.Features.OrderNodes(),
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ program
log('success', 'START')('Testing in', chalk.yellow(folder), '...')
const APP = folder
const SERVE = App.builders[stack].getStaticPath(folder, version)
console.log({ SERVE })

const playwrightFolder = dirname(require.resolve('@playwright/test'))

const { error } = await validateTestRun(APP, SERVE)
Expand Down

0 comments on commit 7d67690

Please sign in to comment.