Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬇️ Test to make sure hidden dropdown elements are not being tagged #141

Merged
merged 9 commits into from
Aug 29, 2024
Merged

⬇️ Test to make sure hidden dropdown elements are not being tagged #141

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd1e532
⬇️ Test to make sure hidden dropdown elements are not being tagged
seanmcguire12 Aug 29, 2024
5be72f8
⬇️ Added testing against page_text
seanmcguire12 Aug 29, 2024
0019518
⬇️ reformat
seanmcguire12 Aug 29, 2024
fafb987
⬇️ test individual characters for expected_tag_string
seanmcguire12 Aug 29, 2024
9ffe029
Merge branch 'main' into APE-140
seanmcguire12 Aug 29, 2024
06bb0a0
add test to make sure hidden dropdown elements are not present in pag…
seanmcguire12 Aug 29, 2024
595fc62
rm print
seanmcguire12 Aug 29, 2024
11f6eb0
Merge branch 'main' into APE-140
seanmcguire12 Aug 29, 2024
2c26b95
🖼️ reformat
seanmcguire12 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/mock_html/dropdown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<title>Title</title>
</head>
<body>
<label>
<select style="font-size: xx-large">
<option value="option1">Option 1</option>
<option value="option2">Option 2</option>
<option value="option3">Option 3</option>
<option value="option4">Option 4</option>
</select>
</label>
</body>
</html>
29 changes: 29 additions & 0 deletions tests/test_elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@
IS_GITHUB_ACTIONS, reason="Skipping language test in CI"
),
),
(
"mock_html/dropdown.html",
{
0: "//html/body/label",
},
["Option 1"],
["[ $ 0 ]"],
),
],
)
async def test_combined_elements_page(
Expand Down Expand Up @@ -192,3 +200,24 @@ async def test_text_nodes_are_query_selectable(async_page):
assert len(tag_to_xpath) == 2
assert await async_page.query_selector(tag_to_xpath[0])
assert await async_page.query_selector(tag_to_xpath[1])


@pytest.mark.asyncio
async def test_dropdown_text_not_shown(tarsier, async_page):
dropdown_html_path = os.path.abspath(
os.path.join(os.path.dirname(__file__), "mock_html/dropdown.html")
)
await async_page.goto(f"file://{dropdown_html_path}")
page_text, tag_to_xpath = await tarsier.page_to_text(
async_page, tag_text_elements=True
)
print("\nPAGE TEXT")
print(page_text)
seanmcguire12 marked this conversation as resolved.
Show resolved Hide resolved

assert "[ $ 1 ]" not in page_text
assert "[ $ 2 ]" not in page_text
assert "[ $ 3 ]" not in page_text
assert "[ $ 4 ]" not in page_text
assert "Option 2" not in page_text
assert "Option 3" not in page_text
assert "Option 4" not in page_text