payload/rpm-ostree: Copy stderr to our output #6019
Conversation
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
I think this will work but trying to test it out locally with |
| args | ||
| ) | ||
| # TODO refactor things so we can log stdout to the program log or journal. | ||
| # For now we just use anaconda's stdout. |
There was a problem hiding this comment.
If you can make it log to Journal, it should be captured even now when something goes wrong - Journal is the de-facto primary log sink for Anaconda these days & what we gather and ask users to attach to bugs. :)
Sure, it would be better if Anaconda got distinct event/callback when something happens, but just making sure everything ends up in Journal would help already. :)
cgwalters
force-pushed
the
rpmostre-err
branch
from
803a1aa to
b766bc5
Compare
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Hello @cgwalters! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-07 20:27:59 UTC |
We have two wrapper function for this which discard one or the other return value. Make the general function "public" with via a non-`_` prefixed name, but keep the old name because there are a number of users. (Eventually we likely want to clean this up more, but it would be highly likely to conflict with other work) Signed-off-by: Colin Walters <[email protected]>
The rpm-ostree container deployment path can fail for many reasons from networking to details in mount setup. What we really want is a proper API with progress out of bootc/ostree; I will work on that at some point. In the meantime though, just capture stderr on failure and include it in the payload installation error so people don't have to dig into `program.log` which is very obscure. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
rpmostre-err
branch
from
b766bc5 to
3895360
Compare
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
OK, I've tested this now with |
The rpm-ostree container deployment path can fail for many reasons from networking to details in mount setup.
What we really want is a proper API with progress out of bootc/ostree; I will work on that at some point.
In the meantime though, just capture stderr on failure and include it in the payload installation error so people don't have to dig into
program.logwhich is very obscure.