Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for keyboard layout control #6067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkonecny12
Copy link
Member

This logic is not trivial and it needs external knowledge to understand. Let's document that for future generations and external contributors.

@github-actions github-actions bot added the f42 Fedora 42 label Dec 20, 2024
@jkonecny12
Copy link
Member Author

/kickstart-test --waive docs only

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one small improvement suggestion. :)

Keyboard layouts installation implementation
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The layout configuration through a graphical interface is set to the ``Localization`` Anaconda module by DBus API setters. The installation is resolved by the installation tasks in the ``installation.py`` file in the ``localization`` Anaconda module.
Copy link
Contributor

@M4rtinK M4rtinK Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be more specific here - eq. "The installation of "something" is resolved...". :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better now?

This logic is not trivial and it needs external knowledge to understand.
Let's document that for future generations and external contributors.
@jkonecny12 jkonecny12 force-pushed the add-localed-documentation branch from e7654e4 to 6f34d7c Compare January 2, 2025 13:18
@jkonecny12
Copy link
Member Author

/kickstart-test --waive docs only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants