-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for keyboard layout control #6067
base: main
Are you sure you want to change the base?
Conversation
/kickstart-test --waive docs only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one small improvement suggestion. :)
docs/developer/keyboard-control.rst
Outdated
Keyboard layouts installation implementation | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
The layout configuration through a graphical interface is set to the ``Localization`` Anaconda module by DBus API setters. The installation is resolved by the installation tasks in the ``installation.py`` file in the ``localization`` Anaconda module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more specific here - eq. "The installation of "something" is resolved...". :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better now?
This logic is not trivial and it needs external knowledge to understand. Let's document that for future generations and external contributors.
e7654e4
to
6f34d7c
Compare
/kickstart-test --waive docs only |
This logic is not trivial and it needs external knowledge to understand. Let's document that for future generations and external contributors.