New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests to use t.Fatal instead of panic #476

Closed

alexandear wants to merge 1 commit into rhysd:main from alexandear:refactor-test-fatal

Contributor

alexandear commented Nov 11, 2024

t.Fatal is specifically designed for use in tests instead of panic. It stops tests execution immediately.


          refactor tests to use t.Fatal instead of panic

c82857b

Owner

rhysd commented Nov 12, 2024 •

edited

Loading

Thanks for sending a patch.

However these panics are intentional.

panic is used when it should never fail due to the error. It's some kind of unreachable!() in Rust.
t.Fatal is used when it should make the test fail.

I distinguish between aborting the test and failing the test.

rhysd closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet