Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Axis2Placement parallel to x-axis without reference #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larsniem
Copy link

Hi,
first thank you for your great work, I really enjoy playing around with it in some little projects so far.

This is also how I stumbled over an untested case in the stepio crate, which caused some trouble. The cause is an AxisPlacement which is parallel to the global x-axis and also no reference is given for the AxisPlacement. The solution is more or less trivial, by just avoiding the artificial reference axis being parallel to the actual axis. Choosing the y-axis instead resolved the issue.

I adopted the existing tests for verification. I'm not really sure if the solution of the issue and tests meet your expectations, there are definitely other possible solutions.

@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants