Handle Axis2Placement parallel to x-axis without reference #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first thank you for your great work, I really enjoy playing around with it in some little projects so far.
This is also how I stumbled over an untested case in the stepio crate, which caused some trouble. The cause is an AxisPlacement which is parallel to the global x-axis and also no reference is given for the AxisPlacement. The solution is more or less trivial, by just avoiding the artificial reference axis being parallel to the actual axis. Choosing the y-axis instead resolved the issue.
I adopted the existing tests for verification. I'm not really sure if the solution of the issue and tests meet your expectations, there are definitely other possible solutions.