-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor pattern matching #50
base: main
Are you sure you want to change the base?
Conversation
This refactors pattern matching
@@ -239,6 +253,7 @@ Nim provides unique features for seamless and transparent interoperability with | |||
|
|||
- [nimcr](https://github.com/PMunch/nimcr) - Running Nim code with Shebangs. | |||
- [nimr](https://github.com/Jeff-Ciesielski/nimr) - Run Nim programs like scripts. | |||
- [glob](https://github.com/citycide/glob) - Pure library for matching file paths against Unix style glob patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be path handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean as an own, new section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes, I also evaluated this to be part of the scripting section.
What about combining the Scripting and the Processes sections together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean as an own, new section?
Yeah, I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
- [ast_pattern_match](https://github.com/krux02/ast-pattern-matching) - A library to do pattern matching on the AST. | ||
|
||
|
||
### Regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New heading needs to be added to the index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done that too, also for the new section "path handling"
@@ -17,6 +17,7 @@ | |||
- [Contracts](#contracts) | |||
- [Object-Oriented Programming](#object-oriented-programming) | |||
- [Functional Programming](#functional-programming) | |||
- [Pattern Matching](#pattern-matching) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old one needs to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern matching category in the index reflects the pattern matching category in real, exactly under the functional programming category.
I wasnt sure, if I should merge them, considering that many Nim users seem to see it on it's own.
Why would you remove that index, but not the real category way down?
This refactors pattern matching