derive: add benchmark #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinja_derive_standalone/Cargo.toml
Outdated
| [features] | ||
| default = ["__standalone"] | ||
| __standalone = [] | ||
| config = ["serde", "basic-toml"] |
There was a problem hiding this comment.
Missing the :dep part you mentioned. ;)
There was a problem hiding this comment.
Hehe, yeah. I leave this task to tomorrow-me. :D
There was a problem hiding this comment.
I approve this way of seeing things! 😆
|
Looks like a great start! Can you add documentation on how to run these benchmarks as well please? |
Kijewski
force-pushed
the
pr-benchmark-derive
branch
2 times, most recently
from
1719626 to
e8e59fc
Compare
Yup, added. |
|
Awesome, when the |
|
Just need to fix the merge conflict and it can get merged. :) |
This PR adds the crate "rinja_derive_standalone", which is just like "rinja_derive", though not a "proc_macro". This way we can easily expose it's internals for testing and benchmarking. Right now, the PR is more or less a prove of concept, and it probably needs a handful more useful benchmark use cases to be worth the hassle.
Kijewski
force-pushed
the
pr-benchmark-derive
branch
from
e8e59fc to
1ce549d
Compare
GuillaumeGomez
approved these changes
Jun 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the crate "rinja_derive_standalone", which is just like "rinja_derive", though not a "proc_macro". This way we can easily expose it's internals for testing and benchmarking.
Right now, the PR is more or less a prove of concept, and it probably needs a handful more useful benchmark use cases to be worth the hassle.
Resolves #12.