Modified the build.sh file to enable separate compilation of each module #5

DennisDing2003 · 2024-12-18T09:26:51Z

Modify build.sh to include options for compiling individual modules separately, which facilitates debugging.

New menu options for easier modular testing and compilation

Add compile all option in brs_compile_component()

Add some comments to make debugging easily. Cc: dahogn <[email protected]> Cc: caiyuqing379 <[email protected]> Cc: meng-cz <[email protected]> Cc: USER0FISH <[email protected]> Signed-off-by: Zixuan Ding <[email protected]>

hubblezzhu · 2024-12-19T01:43:32Z

Hi, @qiaozhe1, please help reviewing this PR

thanks

DennisDing2003 · 2024-12-19T02:03:59Z

Hi @hubblezzhu @qiaozhe1, During the actual compilation process, we have found some problems with the original build.sh script. So we modify build.sh to include options for compiling individual modules separately, which facilitates debugging. Could you please help reviewing it? Thanks.

qiaozhe1 · 2024-12-19T02:28:24Z

Can the option C be changed to automatically compile all components after waiting for a few seconds, hoping to minimize intervention after executing the script?

Change the "C. Compile All Components" option to automatically start execution after a 10-second countdown. Signed-off-by: Zixuan Ding <[email protected]>

DennisDing2003 · 2024-12-19T07:54:43Z

Hi @hubblezzhu @qiaozhe1, I modified brs_compile_component() in build.sh, changing the "C. Compile All Components" option to automatically start execution after a 10-second countdown. Could you please help reviewing it? Thanks.

avpatel · 2024-12-30T13:53:45Z

@vlsunil can you please check this PR ?

vlsunil · 2025-01-02T05:05:18Z

build.sh

+            break  
+            ;;  
+        *)  
+            echo "Invalid option, please try again."  


I am happy to see this enhancement which allows to build components selectively. However, I think we should have previous behavior as well. That is, if the user doesn't select any option within timeout value, then it should be do compile all, create images etc. What do you think?

Ok, we will add this feature, wait for our update.

vlsunil · 2025-01-02T05:10:26Z

build.sh

-    mmd -i $fatpart_name ::/EFI/BOOT/debug
-    mmd -i $fatpart_name ::/EFI/BOOT/app
-
-    mcopy -i $fatpart_name bootriscv64.efi        ::/EFI/BOOT


Why these things are removed? With new changes I see only FAT FS creation. Who will setup files required in EFI/BOOT directory?

Thank you for your feedback. This part was mistakenly deleted, but it has been corrected now. Could you please help reviewing it? Thanks.

Add time counting part in build.sh. Adjust brs_buildimage() in build.sh. Add brs-edk2-test-parser/Makefile so that it can be compiled. Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

Remove the judgment in the secondary menu Signed-off-by:Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

vlsunil · 2025-01-10T05:58:00Z

build.sh

-    popd
-}
+    popd 
+}  


Doesn't look necessary change. An extra space at the end is incorrect.

Thank you for your reminder, we have deleted it in the latest commit.

vlsunil · 2025-01-10T05:58:12Z

build.sh

+    local FAT2_SIZE_MB=128  
+
+    # Assuming 2048 sectors for 1MB
+    local PART_START=$((1 * 2048)) 


Any reason to remove the macro BRS_SEC_PER_MB? I think it is better to keep the macro. Actually, apart from new lines introduced, I don't see any functional change. If so, better not to do such beautification as part of this PR since it takes review time unnecessarily.

Thanks for reminding us, we have added BRS_SEC_PER_MB in the latest commit.

vlsunil · 2025-01-10T06:04:45Z

build.sh

-
-main
+# Start execute  
+show_menu_with_countdown


Is there an extra new line at the end? github diff showing some kind of error.

Yes, there should be a new line, and we have added it at the end.

vlsunil · 2025-01-10T06:53:15Z

build.sh

-    cp $BRS_IMAGE_DIR/$BRS_IMAGE_XZ $TARGET_DIR/
-
+    cp "$BRS_IMAGE_DIR/$BRS_IMAGE_XZ" "$TARGET_DIR/"  
+    


extra spaces

Thanks for reminding us, we have deleted these spaces in the latest commit.

vlsunil · 2025-01-10T07:03:05Z

src/brs-edk2-test-parser/Makefile

+.PHONY: brs-edk2-test-parser
+brs-edk2-test-parser:
+	@echo "Building BRS EDK2-Test-Parser..."
+	git clone -b $(EDK2_TEST_PARSER_VERSION) https://git.gitlab.arm.com/systemready/edk2-test-parser.git


Why do we use ARM repo? Please don't use sources from other architectures.

We only found ARM repo, so we deleted this choice in our latest pull request.

vlsunil · 2025-01-10T07:03:45Z

Please confirm/provide testing results after the changes.

DennisDing2003 · 2025-01-10T07:15:19Z

OK, thanks for your feedback, we will fix these problems as soon as possible.

Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

Riscv brs tests v1.2

USER0FISH and others added 3 commits December 17, 2024 20:37

feat:New build.sh menu

13b9f44

New menu options for easier modular testing and compilation

fix: Add compile all options

96c4441

Add compile all option in brs_compile_component()

fix: Add some comments.

be92872

Add some comments to make debugging easily. Cc: dahogn <[email protected]> Cc: caiyuqing379 <[email protected]> Cc: meng-cz <[email protected]> Cc: USER0FISH <[email protected]> Signed-off-by: Zixuan Ding <[email protected]>

fix: Modify brs_compile_component() in build.sh

fb033d4

Change the "C. Compile All Components" option to automatically start execution after a 10-second countdown. Signed-off-by: Zixuan Ding <[email protected]>

vlsunil reviewed Jan 2, 2025

View reviewed changes

DennisDing2003 and others added 2 commits January 7, 2025 10:31

fix: Modify build.sh

b5b3b6a

Add time counting part in build.sh. Adjust brs_buildimage() in build.sh. Add brs-edk2-test-parser/Makefile so that it can be compiled. Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

fix: Fix unwanted options in build.sh

712e971

Remove the judgment in the secondary menu Signed-off-by:Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

DennisDing2003 force-pushed the riscv-brs-tests_V1.2 branch from 104005c to 712e971 Compare January 9, 2025 03:20

vlsunil reviewed Jan 10, 2025

View reviewed changes

USER0FISH and others added 3 commits January 14, 2025 07:12

fix: Remove spaces and unnecessary components

9100863

Signed-off-by:Zixuan Ding <[email protected]> Co-authored-by: USER0FISH <[email protected]> Cc: Sunil V L <[email protected]>

fix: Add a blank line

6612c83

Merge pull request #4 from USER0FISH/riscv-brs-tests_V1.2

b1f17f5

Riscv brs tests v1.2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified the build.sh file to enable separate compilation of each module #5

Modified the build.sh file to enable separate compilation of each module #5

DennisDing2003 commented Dec 18, 2024

hubblezzhu commented Dec 19, 2024

DennisDing2003 commented Dec 19, 2024

qiaozhe1 commented Dec 19, 2024

DennisDing2003 commented Dec 19, 2024

avpatel commented Dec 30, 2024

vlsunil Jan 2, 2025

USER0FISH Jan 2, 2025

vlsunil Jan 2, 2025

DennisDing2003 Jan 8, 2025

vlsunil Jan 10, 2025

DennisDing2003 Jan 14, 2025

vlsunil Jan 10, 2025

DennisDing2003 Jan 14, 2025

vlsunil Jan 10, 2025

DennisDing2003 Jan 14, 2025

vlsunil Jan 10, 2025

DennisDing2003 Jan 14, 2025

vlsunil Jan 10, 2025

DennisDing2003 Jan 14, 2025

vlsunil commented Jan 10, 2025

DennisDing2003 commented Jan 10, 2025

		cp $BRS_IMAGE_DIR/$BRS_IMAGE_XZ $TARGET_DIR/

		cp "$BRS_IMAGE_DIR/$BRS_IMAGE_XZ" "$TARGET_DIR/"

Modified the build.sh file to enable separate compilation of each module #5

Are you sure you want to change the base?

Modified the build.sh file to enable separate compilation of each module #5

Conversation

DennisDing2003 commented Dec 18, 2024

hubblezzhu commented Dec 19, 2024

DennisDing2003 commented Dec 19, 2024

qiaozhe1 commented Dec 19, 2024

DennisDing2003 commented Dec 19, 2024

avpatel commented Dec 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vlsunil commented Jan 10, 2025

DennisDing2003 commented Jan 10, 2025