Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zcmp spec instructions (encodings and descriptions). #427

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ayosher
Copy link
Collaborator

@ayosher ayosher commented Jan 20, 2025

No description provided.

@ayosher ayosher requested a review from dhower-qc as a code owner January 20, 2025 08:20
Copy link
Collaborator

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Thanks for doing this! Nice work.)

Some of the comments in one instruction apply equally to other similar instructions. Let me know if I need to call them all out.

arch/inst/Zcmp/cm.mva01s.yaml Show resolved Hide resolved
arch/inst/Zcmp/cm.mva01s.yaml Show resolved Hide resolved
arch/inst/Zcmp/cm.pop.yaml Show resolved Hide resolved
arch/inst/Zcmp/cm.push.yaml Outdated Show resolved Hide resolved
arch/inst/Zcmp/cm.push.yaml Outdated Show resolved Hide resolved
arch/inst/Zcmp/cm.pop.yaml Outdated Show resolved Hide resolved
arch/inst/Zcmp/cm.mva01s.yaml Show resolved Hide resolved
@ayosher ayosher requested a review from ThinkOpenly January 21, 2025 19:52
arch/inst/Zcmp/cm.pop.yaml Outdated Show resolved Hide resolved
arch/inst/Zcmp/cm.mva01s.yaml Show resolved Hide resolved
arch/inst/Zcmp/cm.mva01s.yaml Show resolved Hide resolved
arch/inst/Zcmp/cm.pop.yaml Outdated Show resolved Hide resolved
arch/inst/Zcmp/cm.pop.yaml Show resolved Hide resolved
@ayosher ayosher requested a review from ThinkOpenly January 22, 2025 08:16
arch/inst/Zcmp/cm.push.yaml Outdated Show resolved Hide resolved
…removing explanation about spimm

Signed-off-by: Albert Yosher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants