Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text in S.yaml #433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix text in S.yaml #433

wants to merge 1 commit into from

Conversation

dhower-qc
Copy link
Collaborator

Fixes #432

Fixes #432 

Signed-off-by: Derek Hower <[email protected]>
@dhower-qc dhower-qc requested a review from dlweaver January 22, 2025 15:53
@kbroch-rivosinc
Copy link
Collaborator

kbroch-rivosinc commented Jan 22, 2025

I think U-ext has the same issue: https://github.com/riscv-software-src/riscv-unified-db/blob/main/arch/ext/U.yaml#L23

@dlweaver
Copy link
Collaborator

This resolution looks good!

@dlweaver dlweaver closed this Jan 22, 2025
@ThinkOpenly
Copy link
Collaborator

I think this needs to be reopened in order to get U-mode fixed and get everything merged.

@ThinkOpenly ThinkOpenly reopened this Jan 22, 2025
@ThinkOpenly ThinkOpenly changed the title Fox text in S.yaml Fix text in S.yaml Jan 22, 2025
@dlweaver
Copy link
Collaborator

Sorry, Paul -- (as a GitHub newbie,) I thought a new Issue needed to be opened, since U.yaml was a different file.
Happy to leave this open if it can apply to U.yaml as well.

@ThinkOpenly
Copy link
Collaborator

ThinkOpenly commented Jan 22, 2025

Sorry, Paul

No problem! (Just a bit surprising. ;-)

I thought a new Issue needed to be opened, since U.yaml was a different file. Happy to leave this open if it can apply to U.yaml as well.

It can be used for both. Indeed, this is the vehicle for adding the changes, so the proposed change from Derek (and presumably an additional change from Derek for U.yaml) will appear here, where they can be reviewed, approved, and merged. That final act, merging, will automatically close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S extension (S.yaml) -- should refer to S mode, not M mode
4 participants