Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "@" in version descriptors #24

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

selfisekai
Copy link
Contributor

Breaking, again.

Copy link
Owner

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, again.

@robertohuertasm robertohuertasm merged commit cac46aa into robertohuertasm:master Dec 13, 2024
3 checks passed
@riquito
Copy link
Contributor

riquito commented Jan 4, 2025

"breaking, again" is a bit terse as description, we're getting many breaking changes lately, some extra detail would be welcome (perhaps it's time to introduce a CHANGELOG.md file).

I don't get this change, the dependency_version function now doesn't return a version anymore (e.g. it can now return npm:[email protected] || 1.0.1 ). I guess there is a use case, but there's not enough information

@selfisekai
Copy link
Contributor Author

I don't get this change, the dependency_version function now doesn't return a version anymore (e.g. it can now return npm:[email protected] || 1.0.1 ).

In this case, foo is the package actually downloaded from npm, which is a different one than the one it's aliased under. This change was needed to recognize these aliases correctly.

I guess the name dependency_version indeed isn't very precise. The values yarn puts there are exact copies of the descriptors in dependencies of each package's package.json. These are mostly npm version ranges, but this always included values like https://s.lnl.gay/YMSRcUPRNMxx.tgz, isaacs/minimatch#v10.0.1, latest, or ssh://[email protected]/npm/node-semver.git#semver:^7.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants