Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[param]add param angle_compensate_multiple #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kintzhao
Copy link
Collaborator

Default angle_compensate_multiple(Running at 10HZ): 16K -- 4 8K -- 2 4K -- 1
angle_compensate_multiple is min(setting value, default value)

@kerliang0801
Copy link

Hi! I've been diving into the code. Amazing work! Just came across this PR. Even though It's a bit old but correct me if I'm wrong, but would it be better to make the angle_compensate_multiple be a dynamic variable based on the node_counts returned by the sdk? This way, even if one would change the motor frequency (which will in turn change the number of node_counts), the dynamic multiplier can still be "smart" enough to allocate a large enough vector to represent the returned nodes in a distributed manner. For example, if my node_count returns around 700 nodes, then my multiplier will be 2 - or if my node_count returns 340, my multiplier will be 1. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants