Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the stance phase machinery #68

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Sep 18, 2020

This PR should fix the stance phase machinery in the walking module. In theory, the PR fixes #66

Note: before merging it should be tested on iCub

Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the robot. The performances are the same as in #65 (comment)

@S-Dafarra
Copy link
Collaborator

Merging

@S-Dafarra S-Dafarra merged commit 33e9b06 into robotology:devel Sep 18, 2020
@GiulioRomualdi GiulioRomualdi deleted the fix/is_stance_phase branch September 18, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The getIsStancePhase logic on devel is broken
2 participants