Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复embedFS在windows平台下的问题 #77

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

zhengguo07q
Copy link
Contributor

在windows平台下不能读取embedfs里的文件

…m, filepath.Join converts the correct separator to \, so it needs to be replaced with / if using embed.FS on Windows.
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ef931e4) 75.39% compared to head (45cee23) 75.39%.

❗ Current head 45cee23 differs from pull request most recent head 63213a2. Consider uploading reports for the commit 63213a2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files          35       35           
  Lines        4126     4126           
=======================================
  Hits         3111     3111           
- Misses        828      829    +1     
+ Partials      187      186    -1     
Files Coverage Δ
entry/sw_entry.go 52.28% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dongxuny dongxuny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongxuny dongxuny merged commit 1456717 into rookie-ninja:master Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants