Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper $host for FastCGI SERVER_NAME param #1552

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Use proper $host for FastCGI SERVER_NAME param #1552

merged 1 commit into from
Nov 23, 2024

Conversation

strarsis
Copy link
Contributor

@strarsis strarsis commented Nov 23, 2024 •
edited
Loading

This PR adds a fastcgi_param line to wordpress site configuration to ensure that SERVER_NAME FastCGI (PHP) variable is set to $host. This is important as the included default fastcgi_params set SERVER_NAME to $server_name which is set (arbitrarily) to one of the matching hostnames of a site, but not the actual matching one.
Fixes #1550.

@strarsis strarsis mentioned this pull request Nov 23, 2024
Closed
@swalkinshaw swalkinshaw merged commit 0aeed2a into roots:master Nov 23, 2024
2 checks passed
@swalkinshaw
Copy link
Member

Thanks @strarsis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP SERVER_NAME not passed correctly for multiple canonical domains
2 participants
@strarsis @swalkinshaw