Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ControllerMock #1948 #1990

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Wiktor-99
Copy link
Contributor

I was looking at the #1948, and indeed this is an overload and not a overrided method. There is no update method that takes zero arguments. Nevertheless, I've checked and this code is not used in ros2_control nor in any other ros2_control repo. I think this might be deleted.

@github-actions github-actions bot requested a review from arne48 January 9, 2025 09:08
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (b329679) to head (982628f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   89.33%   89.32%   -0.02%     
==========================================
  Files         130      130              
  Lines       14516    14515       -1     
  Branches     1258     1258              
==========================================
- Hits        12968    12965       -3     
+ Misses       1083     1082       -1     
- Partials      465      468       +3     
Flag Coverage Δ
unittests 89.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er_manager/test/controller_manager_test_common.hpp 89.83% <ø> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@destogl destogl merged commit a04416d into ros-controls:master Jan 10, 2025
25 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ControllerMock::update' hides overloaded virtual function
4 participants