Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for copy and move operations of the Handle class #2011

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

No description provided.

@saikishor saikishor force-pushed the add/copy_move/handle/tests branch from 0ad665e to 6615d9b Compare January 21, 2025 13:37
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (d4139b7) to head (715ab29).

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
+ Coverage   89.38%   89.44%   +0.06%     
==========================================
  Files         132      132              
  Lines       14663    14699      +36     
  Branches     1258     1259       +1     
==========================================
+ Hits        13106    13147      +41     
+ Misses       1090     1085       -5     
  Partials      467      467              
Flag Coverage Δ
unittests 89.44% <98.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/test/test_handle.cpp 100.00% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 88.57% <95.45%> (-0.17%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@Wiktor-99 Wiktor-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor
Copy link
Member Author

@Wiktor-99 thanks for the nice suggestions! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value_ptr_ issue when copying/moving hardware_interface::Handle
2 participants